Skip to content

Commit

Permalink
Cover flatshapes (#35)
Browse files Browse the repository at this point in the history
All right! That took some time πŸ•™. Sorry for the long wait, I had _life_
coming in the middle.
Anywho, I finished a bit more of `FlatShape`s
- `FlatShape::StringInterpolation`
- `FlatShape::Block`
- `FlatShape::Closure`
- `FlatShape::InternalCall(declid)`
- `FlatShape::External`
- `FlatShape::ExternalArg`
- `FlatShape::Signature`
- `FlatShape::Keyword`
- `FlatShape::VarDecl(varid)`
- `FlatShape::Variable`

There are a bunch more to solve, but most importantly, the code is
screaming for a refactor.
The issue is that I used more and more booleans to do quick checks "is
this coming from a `def` keyword?" "are we in a string interpolation
line?" and so on, that it gets _very_ spaguetti if we dont use smarter
solutions like `peek` for example

As a conclusion, I am ready for this PR, but I know now that the
direction is not to include all the remaining `FlatShape`s, but
reorganize the code a little better πŸ˜‡

---------

Co-authored-by: amtoine <[email protected]>
Co-authored-by: Auca Maillot <[email protected]>
Co-authored-by: Antoine Stevan <[email protected]>
  • Loading branch information
4 people committed Dec 17, 2023
1 parent 4d57849 commit 995e756
Show file tree
Hide file tree
Showing 6 changed files with 702 additions and 450 deletions.
4 changes: 4 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,7 @@ result

# Direnv
.direnv

# editors
.idea/
.vscode/

0 comments on commit 995e756

Please sign in to comment.