Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add find_msvs custom command to the nu_msvs module #881

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

fdncred
Copy link
Collaborator

@fdncred fdncred commented Jun 18, 2024

I changed export-env {} at the beginning to a custom command to avoid having export-env run when loading the module
because:

  1. I couldn't use nu_msvs activate because it depends on env vars being set that were hidden with nu_msvs deactivate
  2. It seems that export-env executed at use, leaves $env.FILE_PWD available in the environment which I think may be
    a bug. So, putting it in a custom command avoids that.

@fdncred fdncred merged commit ddbebf1 into nushell:main Jun 18, 2024
1 check passed
@fdncred fdncred deleted the update_nu_msvs_with_find_msvs branch June 18, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant