Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add git coommit completions #854

Merged
merged 1 commit into from
May 28, 2024
Merged

Add git coommit completions #854

merged 1 commit into from
May 28, 2024

Conversation

laisnuto
Copy link
Contributor

@laisnuto laisnuto commented May 28, 2024

Improve git commit completions for nushell

@fdncred fdncred merged commit 5ce769c into nushell:main May 28, 2024
1 check passed
@fdncred
Copy link
Collaborator

fdncred commented May 28, 2024

Thanks

fdncred added a commit that referenced this pull request Jun 5, 2024
@fdncred
Copy link
Collaborator

fdncred commented Jun 5, 2024

This PR broke the git aliases https://github.com/nushell/nu_scripts/blob/main/aliases/git/git-aliases.nu so I'm reverting it.

fdncred added a commit that referenced this pull request Jun 5, 2024
@fdncred
Copy link
Collaborator

fdncred commented Jun 5, 2024

I re-re-reverted because of what I discovered here #869

I still think something is wrong but not necessarily here.

@kubouch
Copy link
Contributor

kubouch commented Jun 5, 2024

The alias export alias gcam = git commit --all --message in git-aliases.nu no longer works because you can't alias only a part of a named flag without its value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants