Port before_v0.60/make_release folder
#830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has already been ported to ./make_release/this_week_in_nu_weekly.nu and has received new updates in: 7bff42f
This module has already been ported to `./make_release/get-js-ext.nu` and has received many new small updates for example in: 6947014
move `gen-ts-ext.nu` to `./make_release/` before making changes
- replace `build-string` with `+` and `[...] | str join`
- replace `str collect` with `str join`
- replace `help commands` with `scope commands`
- add `else` in `for {...} {...}`
- prepare for port
- port `fetch` to `http get`
- `else` in `for {...} {...}`
- explicit `$it`
- explicit `print`
- port `each -n` to `enumerate | each`
- port `str collect` to `str join`
39555
changed the title
before_v0.60/make_release folder #221before_v0.60/make_release folder
It has already been moved but not ported from the old version - replace pipeline `for` with `each` - explicit print - port `$nu.scope` to `scope commands`
|
Seems that our CI runs |
39555
force-pushed
the
port-before_v0.60/make-release
branch
from
f3a7fb5
to
3e9e3c3
Compare
fdncred
reviewed
May 13, 2024
| print 'Please set GITHUB_USERNAME and GITHUB_PASSWORD in $env to use this script' | ||
| } else { | ||
| query-week-span | ||
| def main [ |
There was a problem hiding this comment.
I'm not sure it's important that these all be modules, it should work if you just do source script.nu
…nts in `main`" This reverts commit 3e9e3c3.
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of porting all old scripts #221 and ports
make_releasefolderSummary
make_release/this_week_in_nu_weekly.nu
This script has already been ported and has received some updates: #433. So I just removed it
make_release/this_week_in_nu_release.nu
I have ported this, but I'm not sure if we need it because it has strange name and we have
prs.nuandmake_release/release-note/make_release/nu_release.nu
This has already been ported to
make_release/nu_release.nuand has received new updates #828 so I just removed itmake_release/gen-js-ext.nu
This has already been moved to
make_release/gen-js-ext.nuand has received new updates #621 but not completely ported so I have ported itfortoeach$nu.scope.commandstoscope commandsprintmake_release/gen-ts-ext.nu
I have ported this script