Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add windows compatibility for command not found hook #811

Merged
merged 1 commit into from
Apr 7, 2024

Conversation

csc530
Copy link
Contributor

@csc530 csc530 commented Apr 7, 2024

the hook (did_you_mean.nu) had stopped working for me recently, I added an if branch for Windows to use their Path env var (not PATH) and only list files that match in the PATHEXT env var to resolve my issue

look within the `Path` env var for files that match `PATHEXT` extensions
@fdncred
Copy link
Collaborator

fdncred commented Apr 7, 2024

Looks good to me. Thanks!

@fdncred fdncred merged commit 554cb31 into nushell:main Apr 7, 2024
1 check failed
@csc530 csc530 deleted the did-you-mean-hook branch April 7, 2024 20:34
csc530 pushed a commit to csc530/nu_scripts that referenced this pull request Apr 7, 2024
This adds a little command that allows opening .env files as records.
My implementation removes comments and works with both quoted and
unquoted .env files.

add windows compatibility for command not found hook (nushell#811)

the hook (did_you_mean.nu) had stopped working for me recently, I added
an if branch for Windows to use their `Path` env var (not `PATH`) and
only list files that match in the `PATHEXT` env var to resolve my issue
fdncred pushed a commit that referenced this pull request Jul 21, 2024
as per title

## changelog
- "did you mean" improved in #811
- "nuenv" added in #889
- "startup times" added in #888
- "tookit" added in #888
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants