Use cargo hack in release process
#804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nu_release to dry run publishing beforehandcargo hack in release process
sholderbach
approved these changes
Mar 30, 2024
|
|
||
| log warning "publishing the first wave of crates" | ||
| for crate in $subcrates_wave_1 { | ||
| cargo publish -p $crate |
There was a problem hiding this comment.
Ah that's nicer than accidentally ending up in the wrong directory on failure which we encountered in the past. (shouldn't be a problem with the current script due to def scoping, and is nicer anyway.
Comment on lines
+28
to
+37
| - [ ] then, ensure there are no compilation errors with any combination of features by running: | ||
| ```nushell | ||
| cargo hack --all --feature-powerset --skip default-no-clipboard,stable,wasi,mimalloc check | ||
| ``` | ||
| (this will take a while...) | ||
| - [ ] check for build errors by running: | ||
| ```nushell | ||
| cargo hack --all build | ||
| ``` | ||
| (this will build each crate with default features) |
There was a problem hiding this comment.
In my eye that is a slightly different step than the mechanical version bumping (with a cargo check to not miss it in the Cargo.lock) but should do the trick.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two
cargo hackcommands to the release process to check for errors due to combination of features. The first one will runcargo checkon each crate multiple times over, toggling different combinations of features each time. This is to check for compilation errors regarding missing imports, etc. The second command will runcargo buildfor each crate separately (with default features) to check for build errors (frombuild.rsor whatever).Using the error from the 0.90.0 publishing as a test, the first command does indeed find the compilation error.
In the future, we should probably put these commands into a manually triggered CI job so that they will be run on multiple platforms.
Also, this PR cleans up
nu_release.nua little bit.