Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for catppuccin-latte #741

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Support for catppuccin-latte #741

merged 1 commit into from
Mar 7, 2024

Conversation

apraga
Copy link
Contributor

@apraga apraga commented Jan 21, 2024

Complete the support for catppucin-mocha.

It looks like there's work for a better way to manage that ( catppuccin/catppuccin#2140 ) but this can help other people.

@fdncred
Copy link
Collaborator

fdncred commented Jan 21, 2024

I'm fine with landing this as is, but there is a recent shape that's very helpful.

shape_external_resolved

This shape combined with highlight_resolved_externals: true set in your config.nu will allow external executables to be highlighted in a "found" color and "not-found" color if it's not found.

I currently use these settings.

  shape_internalcall: cyan_bold # color for resolved internals
  shape_external: darkorange # color for unresolved externals
  shape_external_resolved: light_yellow_bold # color for resolved externals

@amtoine
Copy link
Member

amtoine commented Jan 22, 2024

@fdncred
the build script for the themes would have to be changed as well to accomodate a new theme entry.
i would leave that to another common PR :)

Copy link
Member

@amtoine amtoine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you add a screenshot of this new theme to the screenshots/ directory? 😇

@fdncred will likely know the procedure for this 😌

@fdncred
Copy link
Collaborator

fdncred commented Jan 22, 2024

all the themes need to be updated with the new shape_external_resolved shape. i'm not hyped to generate all the png themes again. But I just follow the preview-*.nu scripts to generate screenshots.

@fdncred
Copy link
Collaborator

fdncred commented Mar 7, 2024

maybe i'll get around to screenshots again someday?

@fdncred fdncred merged commit 74f23a4 into nushell:main Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants