Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

comma test runner #715

Merged
merged 38 commits into from
Dec 29, 2023
Merged

comma test runner #715

merged 38 commits into from
Dec 29, 2023

Conversation

fj0r
Copy link
Contributor

@fj0r fj0r commented Dec 23, 2023

  • Stabilized the format
  • Test suit runner
  • Support batch mode
  • Watch supports postpone
  • settings.theme
  • docker.nu Simplify process-list logic

@fj0r fj0r force-pushed the comma branch 2 times, most recently from e91bfa6 to 8230667 Compare December 24, 2023 07:56
@fj0r fj0r force-pushed the comma branch 3 times, most recently from 56a6e60 to 545855b Compare December 24, 2023 16:09
@fj0r
Copy link
Contributor Author

fj0r commented Dec 26, 2023

basic vscode-tasks support
202312262315_1059x1044
202312262315_1035x1018
202312262316_775x221

@fj0r fj0r force-pushed the comma branch 4 times, most recently from 4da9c6f to 00c50a8 Compare December 26, 2023 15:59
@fj0r fj0r force-pushed the comma branch 2 times, most recently from 76a8f83 to 63de87f Compare December 29, 2023 10:36
When watch or filter exists but description does not exist
description is displayed as watch and filter
@fdncred
Copy link
Collaborator

fdncred commented Dec 29, 2023

I really don't get what's going on here. Why are you pushing all these commits? This type of development is meant to be done in your personal repo, not nu_scripts.

@fj0r
Copy link
Contributor Author

fj0r commented Dec 29, 2023

Things are definitely a bit confusing right now. In the beginning I just needed a task runner with simple autocompletion, which in my estimation was probably a few dozen lines of code. In the process of doing it, I came up with some other ideas and added some functions, and finally it became what it is now.
I will consider creating a new repository, although it is almost complete, it may not be necessary. After some testing, it can now be used normally. If so, will it be merged now?

@fj0r fj0r marked this pull request as ready for review December 29, 2023 14:02
@fdncred
Copy link
Collaborator

fdncred commented Dec 29, 2023

this is the last time. please don't use our repo for your development. create your own repo and perfect your scripts there. then, if you want to share with us, send us your final version.

@fdncred fdncred merged commit 9b7c177 into nushell:main Dec 29, 2023
@fj0r
Copy link
Contributor Author

fj0r commented Dec 30, 2023

Okay, but to be clear, I didn't mean to do this subjectively. Maybe you have great passion and end up writing only a few dozen lines of code, or maybe you just want to easily write a few lines of code and end up writing thousands of lines. The difficulty is that the future is unpredictable and estimates are always biased.

@fdncred
Copy link
Collaborator

fdncred commented Dec 30, 2023

I'm fine with final scripts like this but developed on your own repo and shared with nu_scripts once you've got it where you like it and won't be changing it much. It's not about whether you meant to do it or not. If you started out in your own repo, then I wouldn't be making these comments.

@fj0r
Copy link
Contributor Author

fj0r commented Dec 30, 2023

This may be my problem, setting up a new repository feels too stressful for me. For no particular reason, I don't want to create a new repository. I will try to make changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants