nu-complete kube deploys and pods #682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- update `kadm check` and `kadm renew`
- refactor `nu-complete kube pods or deploys` to `nu-complete kube deploys and pods`
in nushell#680, `nu-complete kube pods` changed to `pods or deploys`, This has caused some problems:
- double the number of candidates, and candidates with prefix `pods/` and `deployment.apps/`, looks a little confused
- two requests in one completion, slower
considering `deployment` relative `pod` is not so common in `ka` or
'kl', i wrote `nu-complete kube deploys and pods`, it's completed in two stages
- first it will complete the `deployment` and add a suffix `-` when
token not ends-with `-`
- if token ends-with `-`, it's considered unfinished `pod` and
complete the `pod`
- when `ka` or `kl` accepts an argument with suffix `-`, it'll be rewritten as `$"deployment/($pod | str substring ..-1)"`
fj0r
force-pushed
the
main
branch
3 times, most recently
from
03db897
to
015897e
Compare
|
This |
|
Yeah, at least it's name makes sense. it's not exactly same as the original |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kadm checkandkadm renewnu-complete kube pods or deploystonu-complete kube deploys and podsin #680,
nu-complete kube podschanged topods or deploys, This has caused some problems:pods/anddeployment.apps/, looks a little confusedi wrote
nu-complete kube deploys and pods, it's completed in two stagesdeploymentand add a suffix-when token not ends-with-kaorklaccepts an argument with suffix-, it'll be rewritten as$"deployment/($pod | str substring ..-1)"-, it's considered unfinishedpodand continues