Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add str append to stdlib-candidate #626

Merged
merged 2 commits into from
Sep 30, 2023
Merged

Add str append to stdlib-candidate #626

merged 2 commits into from
Sep 30, 2023

Conversation

savente93
Copy link
Contributor

As discussed in nushell/nushell#10486 I've added an stdlib-candidate folder where we can add scripts that might want to be in std-lib at some point. Currently it only contains str append and str prepend which work about how you'd expect. Thanks to @amtoine for writing the initial function. I added a default branch that just returns the input unaltered so it can be used more easily in the middle of a pipe.

@fdncred
Copy link
Collaborator

fdncred commented Sep 30, 2023

This is great! Thanks! Would you mind putting a readme.md in the folder describing what this folder is for? Like what you said above? Just so, when other people look into this folder, they have some idea of what is going on.

@savente93
Copy link
Contributor Author

good one! one sec.

@fdncred
Copy link
Collaborator

fdncred commented Sep 30, 2023

Nice words in the readme. Thanks!

@fdncred fdncred merged commit 20a297b into nushell:main Sep 30, 2023
@savente93 savente93 deleted the str-append branch September 30, 2023 22:30
@amtoine
Copy link
Member

amtoine commented Oct 1, 2023

i like this idea 👌

@savente93
could you add tests for these two commands as well? that'd be perfect 😇

@savente93
Copy link
Contributor Author

sure thing, I'll try and open a PR somwhere today if I have time!

@amtoine
Copy link
Member

amtoine commented Oct 1, 2023

amazing 🙏

just some

#[test]
def test_1 [] {
    ...
}

next to the definitions should be enough 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants