Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use $env. instead of let-env #543

Merged
merged 1 commit into from
Jul 1, 2023
Merged

Conversation

amtoine
Copy link
Member

@amtoine amtoine commented Jul 1, 2023

related to nushell/nushell#9574

this PR moves from using let-env FOO = ... to using $env.FOO = ... in all the nu_scripts.

procedure

this was an automatic commit, i've simply run the following commands 👍

sd --string-mode "let-env " '$env.' **/*
git rst before_v0.60/

cc/ @jntrnr

related to nushell/nushell#9574

Commands used
```nushell
sd --string-mode "let-env " '$env.' **/*
git rst before_v0.60/
```
@amtoine
Copy link
Member Author

amtoine commented Jul 1, 2023

yeah 🥳
thanks a lot for the super quick reviews 😊

@amtoine amtoine merged commit a61256d into nushell:main Jul 1, 2023
@amtoine amtoine deleted the let-env-is-deprecated branch July 1, 2023 08:40
@pedoc pedoc mentioned this pull request Jul 10, 2023
@neur1n
Copy link
Contributor

neur1n commented Aug 12, 2023

Thanks a lot for your effort! I didn't have time to upgrade my scripts to work with 0.83 until today and then I found this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants