add missing colors to the themes #520
Conversation
NOTE: color1 should be red-ish and color7 should be white-ish.
these keys are "background", "foreground" and "cursor".
|
I think we need to wait on this one until the nushell feature lands, but glad you're keeping up with the changes. I've also been thinking about porting this folder. This folder allows you to change the terminal theme (not nushell) if your terminal supports OSC 4,5,10,17,19 escapes. |
|
|
||
| background: dark_gray | ||
| foreground: default | ||
| cursor: red |
There was a problem hiding this comment.
cursor: red? seems like an odd choice. aren't most cursors are the same color as text?
There was a problem hiding this comment.
yeah to be honest i had no idea what color to use here 😬
so do we go with default? 😋
btw, when i add the following to my
config.nu, after the theme is set$env.config.color_config.cursor = redit does not change anything around the cursor in the REPL 🤔
yes that's a good idea 👍
i dunno, i use |
|
oooh but nushell/nushell#9326 has landed so we can work with this one now 😉 |
|
yup, sounds good to me. i just have to generate all my friggin screenshots again, lol |
😬 😆 |
related to
in this PR, i've
search_resultkey introduced in use "search_result" style to colorize matching strings (fixes #9275) nushell#9326 to thenushell-*themes manually and to themake.nutemplatebackground,foregroundandcursorto thenushell-*themes manually to make create readme.md with theme previews #519 work with all the themes