Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: add term-dark and term-light themes from main nushell #500

Merged
merged 2 commits into from
May 18, 2023

Conversation

amtoine
Copy link
Member

@amtoine amtoine commented May 17, 2023

i like having my Nushell theme follow the theme of my terminal by using only named colors, e.g. white and red instead of things like #aaaaaa and #cc2222 😋

as the themes in default_config.nu do both exactly that, i've copy-pasted them as themes/themes/term-dark.nu and themes/themes/term-light.nu for dark_theme and light_theme respectively 😌

@amtoine amtoine added the enhancement New feature or request label May 17, 2023
@amtoine amtoine self-assigned this May 17, 2023
@fdncred
Copy link
Collaborator

fdncred commented May 17, 2023

i don't understand what this is. Is this a personal theme? The nushell theme?

@amtoine
Copy link
Member Author

amtoine commented May 17, 2023

i don't understand what this is. Is this a personal theme? The nushell theme?

it is the official theme, 💯 % pure copy from the default_config.nu from Nushell 👍

up until now, i had to

  • download defaul_config.nu locally
  • make it available through NU_LIB_DIRS
  • source it from config.nu with source default_config.nu
  • set the colorscheme with $env.config.color_config = $dark_theme

this is a bit of a pain 😕
i try to mitigate this here

@fdncred
Copy link
Collaborator

fdncred commented May 17, 2023

it is the official theme

ok, i'm cool with that, but can we name it nushell-dark.nu and nushell-light.nu or something like that as a sign of what it really is?

@amtoine
Copy link
Member Author

amtoine commented May 18, 2023

yeah, no problem 😋

i've named them term-{dark,light} originally because these themes follow the color palette set by the terminal 😏
but yeah it's also the official nushell themes 👍

@fdncred fdncred merged commit 7715868 into nushell:main May 18, 2023
@fdncred
Copy link
Collaborator

fdncred commented May 18, 2023

thanks

@amtoine amtoine deleted the feature/add-terminal-following-themes branch May 18, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants