Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEATURE: allow to run themes/make script from anywhere #499

Merged
merged 2 commits into from
May 17, 2023
Merged

FEATURE: allow to run themes/make script from anywhere #499

merged 2 commits into from
May 17, 2023

Conversation

amtoine
Copy link
Member

@amtoine amtoine commented May 17, 2023

this PR makes it so that one can run either ./themes/make.nu or cd into themes/ and then ./make.nu 馃憤

before this PR, this could have some.... unexpected results 馃憖

i also thought we could ignore the themes/lemnos/ directory generated by themes/make.nu locally inside themes/ 馃槍

@amtoine amtoine added the bug Something isn't working label May 17, 2023
@amtoine amtoine self-assigned this May 17, 2023
@fdncred fdncred merged commit 792d8e3 into nushell:main May 17, 2023
@fdncred
Copy link
Collaborator

fdncred commented May 17, 2023

thanks

@amtoine amtoine deleted the feature/themes/allow-to-run-make-script-from-anywhere branch May 17, 2023 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@amtoine amtoine

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@amtoine @fdncred