refactor: ✨ #418
refactor: ✨ #418
Conversation
Eveything in modules should probably be changed to `exported` defs. The idea is to move everything first to keep proper history.
There was a problem hiding this comment.
Doesn't work on version 0.76.1
Needs update to use main as module name.
There was a problem hiding this comment.
This is an alias so it should be sourced, but there are a few issues that I'm not 100% sure about, cc @fdncred :
from iniis listed in the doc, but I don't have it locally, not sure if it's an optional feature.- It uses
forin pipelines which apparently is not supported anymore, at least not as is
modules/api_wrappers/wolframalpha.nu
Outdated
There was a problem hiding this comment.
Doesn't work on version 0.76.1
Uses fetch instead of newer http get
replaced the template to use `main` and regenerated them from lemnos themes.
|
the themes do not work on latest |
modules/filesystem/up.nu
Outdated
There was a problem hiding this comment.
Doesn't work on version 0.76.1
Nice I did not see that PR it's fixed in the last commit here too |
|
wow, this is a big commit. I'm wondering how we can manage this better. I mean, I expect that moving files around is a big commit and that's no biggy, but moving and changing files may be hard to manage. Thoughts? |
Yep the only reason is the themes that are all broken but solved in #402. I'm going to revert this commit so it's easier to navigate but not sure of the best approach either. |
|
I checked this PR out and I generally like the folder structure. However, I think it would be better to have a There are also a few stragglers that we may need to move. Maybe git should be in helpers or cool-oneliners. Now that I think about it. Everything in this repo is a helper. So, I'm not sure what helpers is about really. nu_101 seems out of place maybe. I think the rest are fine. |
That's a great idea to make the changes more progressively/in subsequent PRs to either fix or convert to module, I will do that today.
Agreed I haven't deeply tested the git "helpers" and wasn't sure where to put them yet :) |
- Created a source `root` in which sourcable demos are stored. Some might get converted to modules later on. - Moved some files to bin too.
|
Thanks for the notes and moving some of the files. Looks like a good start. I'll keep watching. |
|
Totally love the idea of reorganizing but this is beginning to bit-rot. @melMass Do you think you'll have any more time to work on this in the near future? |
|
@fdncred Indeed! I can rebase/update it before Wednesday. |
|
sounds good. it should be pretty easy to separate modules from scripts just by looking for |
|
Merged main back! |
|
@melMass I moved some other stuff around |
You seem to have introduce conflicts or it's from other merge in main? Edit: Actually looking at the history in main and the conflicting files in this PR I have no idea what happened. I will inverstigate this evening! |
|
I thought the conflicts are there because of another PR that has just landed that updated most of these files. |
Yep my bad! Commits from yesterday indeed, I'll solve it locally now! |
Here is the renames for a simpler overview, the rest of the edits are properly commented , separated per commit:
Output of:
git log $"(git merge-base FETCH_HEAD main)..HEAD" -M5 --summary | rg -e 'rename.*=>|delete mode' | lines | str trim | parse '{operation} {file}' | sort-by operation | save -f what_changed.csvExpand for details...