-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add a collection of colorschemes for nushell
#286
Conversation
remove the useless colors.nu script
the `map.csv` file: ```csv code,bold,bash,nushell 0,false,black,black 1,false,red,red 2,false,green,green 3,false,yellow,yellow 4,false,blue,blue 5,false,magenta,purple 6,false,cyan,cyan 7,false,white,light_gray 8,true,black,dark_gray 9,true,red,red_bold 10,true,green,green_bold 11,true,yellow,yellow_bold 12,true,blue,blue_bold 13,true,magenta,purple_bold 14,true,cyan,light_cyan 14,true,cyan,cyan_bold 15,true,white,white ``` the command used was ```nushell open map.csv | each { |it| sed -i $"s/: ($it.nushell)$/: \"{{color($it.code)}}\"/" template.nu } ``` or as a oneliner ```nushell open map.csv | each {|it| sed -i $"s/: ($it.nushell)$/: \"{{color($it.code)}}\"/" template.nu} ```
Nice! Here are some thoughts.
|
the submodule can be deleted afterwards, definitely
nope, that's my fault
that's coool 😋 glad you like the PR 😌 |
i made it a draft until we're ready to land. |
This commit adds the background, the foreground and the cursor colors to the themes as commented lines. These do not fit into any nushell theme as they should be set by the terminal emulator, but they are included here for completeness. Addresses nushell#286 (comment)
hello there 👋 i've changed the remaining caveats
> ./make.nu
3024
3024-day
...
yachiyo
zenburn
Error: nu::shell::name_not_found (link)
× Name not found
╭─[./make.nu:18:1]
18 │ |it|
19 │ sed -i $"s/{{($it.name)}}/($it.rgb)/g" $theme_file
· ─┬─
· ╰── did you mean 'name'?
20 │ }
╰──── but the |
Looking good but we need to remove |
cool, i'll work on that then 😋 EDIT: that should be great in 9c38696 👌 |
ok, nice! it looks good. now we just have to remove the sub module and you already have the attribution. so this is looking very close to me. |
nice work @amtoine. let's land this. appreciate you working with me. ❤️ |
@amtoine Thank you, I really love this. Just select one theme for my usage :-D |
This PR addesses #285.
Current implementation
./themes/lemnos/
to easily update them as the source repo changestemplate.nu
-> it is just a rewrite of the default dark theme with the standard "colorxx" names in replacementmake.nu
file which converts the files from./themes/lemnos/themes/
to usablenushell
modules in./themes/themes/
README
Open discussions
nushell
themes? i've tried the commands in theREADME
a few times but it's hard to tell what could be improved in the template for better themes 🤔To test the themes
Please run