Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

main branch CI is not working as expected #789

Closed
AucaCoyan opened this issue Mar 12, 2024 · 1 comment · Fixed by #791
Closed

main branch CI is not working as expected #789

AucaCoyan opened this issue Mar 12, 2024 · 1 comment · Fixed by #791

Comments

@AucaCoyan
Copy link
Contributor

Since #771 , PR CI is working properly, but main branch CI is passing... weird, I expected it to fail because there are a bunch of files that don't pass the parser check.
When I read the CI log, I found that no file was checked:

Run nu ./check-files.nu
💚 All files checked!

And after I replicate the case in my local,

use toolkit.nu *; generate-file-list --full"
checking all files...

This generate a empty list of files.

This is probably the cause:

mut $files = glob **/*.nu --exclude [before_v0.60/**]

If you remove the mut, glob fails the parser. I need to investigate how glob works

@AucaCoyan AucaCoyan changed the title main CI is not working as expected main branch CI is not working as expected Mar 12, 2024
@AucaCoyan
Copy link
Contributor Author

Reminder for later:
add a badge on the README.md so we know when the CI is passing or not

kubouch pushed a commit that referenced this issue Mar 15, 2024
Closes #789 🍻

- Runs without first generating a script
- Returns error (file) count
- Requires `--and-exit` to exit with error code
- Enables alternative report with env `STUB_IDE_CHECK=true`
- Expands documentation
- All subcommands share same file querying
- Prepares for nupm test integration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant