Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nightly is broken on Linux and Mac #15

Closed
amtoine opened this issue Nov 23, 2023 · 3 comments
Closed

nightly is broken on Linux and Mac #15

amtoine opened this issue Nov 23, 2023 · 3 comments

Comments

@amtoine
Copy link
Member

amtoine commented Nov 23, 2023

looking at this line in the latest nightly action, it looks like the cross-compilation did not run well 😮

the result is that all build files apart from LICENSE could not get copied to the tarballs and thus they end up empty 😢

@hustcer
could you have a look when you get a moment? 😇

@hustcer
Copy link
Collaborator

hustcer commented Nov 23, 2023

OK, thanks for reporting,i guess we should keep sleep 3sec

hustcer added a commit to nushell/nushell that referenced this issue Nov 23, 2023
Try to exit the job if creating binary package failed, related issue:
nushell/nightly#15
hustcer added a commit to nushell/nushell that referenced this issue Nov 24, 2023
Fix release and nightly build workflow:
nushell/nightly#15
I think the `mv` command in v0.87.1 still has some bugs, when downgrade
to v0.86 everything works as expected
@hustcer
Copy link
Collaborator

hustcer commented Nov 24, 2023

I have delete all the bad releases, this issue should be fixed by nushell/nushell#11146.
Let's wait and see.

@hustcer hustcer closed this as completed Nov 24, 2023
@amtoine
Copy link
Member Author

amtoine commented Nov 24, 2023

amazing, thanks 🙏

my nightly update alias works like a charm now 😌

hardfau1t pushed a commit to hardfau1t/nushell that referenced this issue Dec 14, 2023
Try to exit the job if creating binary package failed, related issue:
nushell/nightly#15
hardfau1t pushed a commit to hardfau1t/nushell that referenced this issue Dec 14, 2023
Fix release and nightly build workflow:
nushell/nightly#15
I think the `mv` command in v0.87.1 still has some bugs, when downgrade
to v0.86 everything works as expected
hustcer pushed a commit that referenced this issue Jan 26, 2024
# Description
This is a follow up to: #11365

After this pr, `--flag: bool` is no longer allowed.

I think `ParseWarning::Deprecated` is useful when we want to deprecated
something at syntax level, so I just leave it there for now.

# User-Facing Changes
## Before
```
❯ def foo [--b: bool] {}
Error:   × Deprecated: --flag: bool
   ╭─[entry #15:1:1]
 1 │ def foo [--b: bool] {}
   ·               ──┬─
   ·                 ╰── `--flag: bool` is deprecated and will be removed in 0.90. Please use `--flag` instead, more info: https://www.nushell.sh/book/custom_commands.html
   ╰────
```

## After
```
❯ def foo [--b: bool] {}
Error:   × Type annotations are not allowed for boolean switches.
   ╭─[entry #2:1:1]
 1 │ def foo [--b: bool] {}
   ·               ──┬─
   ·                 ╰── Remove the `: bool` type annotation.
   ╰────
```
# Tests + Formatting
Done
dmatos2012 pushed a commit to dmatos2012/nushell that referenced this issue Feb 20, 2024
Try to exit the job if creating binary package failed, related issue:
nushell/nightly#15
dmatos2012 pushed a commit to dmatos2012/nushell that referenced this issue Feb 20, 2024
Fix release and nightly build workflow:
nushell/nightly#15
I think the `mv` command in v0.87.1 still has some bugs, when downgrade
to v0.86 everything works as expected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants