Skip to content
This repository has been archived by the owner on Feb 8, 2022. It is now read-only.

Better print out for stream output #62

Merged
merged 2 commits into from
Sep 24, 2021
Merged

Conversation

elferherrera
Copy link
Contributor

@elferherrera elferherrera commented Sep 24, 2021

Corrected bug with channel. Using sync_channel was blocking some external commands, like rg.

Things that still need correction:

  • When using cat (probably only windows) the prompt gets mangled and it can only be seen as bytes. It goes back to normal after typing something and pressing enter
    image

  • Python commands are not sent to stdout. If we send python -c "print('hello')" the output is missed. However we can enter a python shell without problem

  • The use of ^ for marking and external command. Now git cannot be used because there is a git command in engine-q

@sophiajt sophiajt merged commit d1da75d into nushell:main Sep 24, 2021
@sophiajt
Copy link
Contributor

In Linux, passing args to Python seems okay:

〉python3 -c "print('hello')" | each { $"($it) is good" }
[hello
 is good]

@elferherrera elferherrera deleted the lines branch September 25, 2021 19:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants