This repository has been archived by the owner on Feb 8, 2022. It is now read-only.
Port keep, keep while and keep until commands
#384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we also have a basic |
Yep, I'll add it ASAP 😄 |
|
converted to draft until the requested changes are made. thanks for the work so far! |
|
@arthur-targaryen are you going to be able to finish this up or are you too busy at the moment? |
Sorry I've been a bit busy. I'll find the time to finish this today! |
ghost
changed the title
KeepWhile and KeepUntil commandskeep, keep while and keep until commands
ghost
marked this pull request as ready for review
|
Looks good! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
keep nwas not listed in #242. I assume it's becausefirst(n)would do the same, so I didn't implement it.