Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Handle .git extensions in repository URLs #41

Merged
merged 3 commits into from
Apr 20, 2024
Merged

Conversation

FMotalleb
Copy link
Contributor

Fixing an error reported #32 (comment)

The main issue was that one of the plugins in the config file had a .git extension at the end of the repository URL.

url: https://github.com/pdenapo/nu_plugin_dpkgtable.git

To address this issue, we implemented two steps:

  1. The script will now replace .git extensions with an empty string in URLs, ensuring that the script can correctly locate the Cargo.toml file.
  2. If this issue arises again in the future, the script will handle it more robustly by omitting the affected plugin's data instead of crashing entirely.

@fdncred
Copy link
Collaborator

fdncred commented Apr 20, 2024

Awe, I wondered if the data was corrupt. I looked but didn't see that. Thanks for fixing it.

@fdncred fdncred merged commit 344529e into nushell:main Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants