Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add nu_plugin_image plugin #34

Merged
merged 4 commits into from
Dec 10, 2023
Merged

add nu_plugin_image plugin #34

merged 4 commits into from
Dec 10, 2023

Conversation

FMotalleb
Copy link
Contributor

adds two commands

  • from png: open png files in terminal
  • to png: converts ansi outputs colored texts, tables, etc into image file

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you happen to know why this file is changing all of a sudden? 🤔

@FMotalleb
Copy link
Contributor Author

I added a null check where (I think) was the cause of the issue and from the output it most likely is

EvalBlockWithInput(Span { start: 107690, end: 107694 }, [CantFindColumn { col_name: "plugin", span: Span { start: 114641, end: 114647 }, src_span: Span { start: 114634, end: 114640 } }])

@fdncred
Copy link
Collaborator

fdncred commented Dec 10, 2023

I'm fine with landing this but I think all those eprintln messages should be put behind a --verbose flag.

@fdncred fdncred merged commit 3d12969 into nushell:main Dec 10, 2023
@FMotalleb
Copy link
Contributor Author

FMotalleb commented Dec 11, 2023

I'm fine with landing this but I think all those eprintln messages should be put behind a --verbose flag.

done, forgot to push and merge things

@fdncred
Copy link
Collaborator

fdncred commented Dec 11, 2023

Thanks. Looks good. I really like this plugin.

@FMotalleb
Copy link
Contributor Author

Sadly, for now time is tight but Ill update from png and fix its low resolution issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants