Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: detailed plugin list #28

Merged
merged 17 commits into from
Nov 16, 2023
Merged

Feat: detailed plugin list #28

merged 17 commits into from
Nov 16, 2023

Conversation

FMotalleb
Copy link
Contributor

@FMotalleb FMotalleb commented Nov 15, 2023

A workflow to keep track of nu-plugin and nu-protocol version of the plugins

@fdncred
Copy link
Collaborator

fdncred commented Nov 15, 2023

I think this really looks super! Thanks! The only things that kind of concerns me of this is...

  1. When we add new plugins, I think we need to add it in this CI. It would be great to have a short readme that says, "When you add new plugins, do this..."
  2. Hopefully the syntax of nushell isn't going to change greatly, but if it does, that's a pretty big script. Not complaining really, just not wanting to change it if we have some breaking syntax change.
  3. Lastly, I think we need a link off of the main readme.md that points to the detailed list. I still want to maintain the one-liner plugins section, but we should link to the details somewhere.

@FMotalleb
Copy link
Contributor Author

I understand, but the workflow asks what version of nushell it uses so I think simple nushell updates (solely) won't break this workflow but upgrading the workflow's nushell version may cause this issue.

added a link to plugin_details.md under the plugin section (it is broken for now because it links it to the nushell/awesome-nu and the file is not there yet)

added a link and an instruction on how to add your own plugin under the plugin section.

Copy link
Collaborator

@fdncred fdncred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good now. thanks for all this!

@fdncred fdncred merged commit 3c0362e into nushell:main Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants