fix app crash when bar chart data is empty

nuruy · Sep 14, 2023 · 160c240 · 160c240
1 parent 3b1dcc5
commit 160c240
Show file tree

Hide file tree

Showing 4 changed files with 25 additions and 7 deletions.
diff --git a/src/components/ECharts/BarChart/Stacked.tsx b/src/components/ECharts/BarChart/Stacked.tsx
@@ -49,12 +49,6 @@ export interface IStackedBarChartProps extends Omit<IChartProps, 'title' | 'char
 	showLegend?: boolean
 }
 
-type series = Array<{
-	data: [Date, number][]
-	type: 'bar'
-	stack: 'value'
-}>
-
 export default function StackedBarChart({
 	chartData,
 	valueSymbol = '$',
@@ -69,7 +63,7 @@ export default function StackedBarChart({
 	const [isDark] = useDarkModeManager()
 	const series = useMemo(() => {
 		const chartColor = color || stringToColour()
-		const series: series = chartData.map((cd) => {
+		const series = chartData.map((cd) => {
 			return {
 				name: cd.name,
 				type: 'bar',
@@ -93,6 +87,12 @@ export default function StackedBarChart({
 			}
 		})
 
+		series.forEach((seriesItem) => {
+			if (seriesItem.data.length === 0) {
+				seriesItem.large = false
+			}
+		})
+
 		return series
 	}, [chartData, color, stackColors])
 

diff --git a/src/components/ECharts/BarChart/index.tsx b/src/components/ECharts/BarChart/index.tsx
@@ -115,6 +115,12 @@ export default function BarChart({
 				})
 			})
 
+			series.forEach((seriesItem) => {
+				if (seriesItem.data.length === 0) {
+					seriesItem.large = false
+				}
+			})
+
 			return series
 		}
 	}, [barWidths, chartData, color, defaultStacks, seriesConfig, stackColors, stackKeys, selectedStacks, isMonthly])

diff --git a/src/components/ECharts/ProtocolChart/index.tsx b/src/components/ECharts/ProtocolChart/index.tsx
@@ -257,6 +257,12 @@ export default function AreaBarChart({
 			}
 		}
 
+		series.forEach((seriesItem) => {
+			if (seriesItem.data.length === 0) {
+				seriesItem.large = false
+			}
+		})
+
 		return { series, yAxisByIndex }
 	}, [
 		chartData,

diff --git a/src/components/LiquidationsPage/utils.ts b/src/components/LiquidationsPage/utils.ts
@@ -65,6 +65,12 @@ export const getOption = (
 		}))
 	}
 
+	series.forEach((seriesItem) => {
+		if (seriesItem.data.length === 0) {
+			seriesItem.large = false
+		}
+	})
+
 	const option: ECBasicOption = {
 		graphic: {
 			type: 'image',