feat(config): make min-requirements configurable through file #362
Conversation
commit 1e07842 Author: devyk <[email protected]> Date: Mon Feb 24 03:16:58 2020 +0200 docs(config): document requirements config option commit b5254cf Author: devyk <[email protected]> Date: Mon Feb 24 02:49:20 2020 +0200 fix: resolve insights warnings commit c3849e4 Author: devyk <[email protected]> Date: Mon Feb 24 02:44:59 2020 +0200 refactor(config): make resolve accept general input interface commit e373eb3 Merge: 87c274c 1968d4f Author: devyk <[email protected]> Date: Wed Feb 19 02:38:07 2020 +0200 Merge branch 'master' of github.com:devyk/phpinsights commit 87c274c Author: devyk <[email protected]> Date: Sat Feb 15 17:52:42 2020 +0200 feat(config): make min-requirements configurable through file commit 43f36b4 Author: devyk <[email protected]> Date: Sat Feb 15 17:05:59 2020 +0200 feat(config): make min-requirements configurable through file
There was a problem hiding this comment.
@olivernybroe Sorry for delay with this PR, I was quite busy this week.
Decided to finalize it properly and prepare it for further improvement, so refactored it as we initially agreed. Changed resolve method signature to accept input interface, directory resolving and requirement merge now happens inside resolve method. Because of that I was ought to modify multiple tests, so it might be reasonable to take a closer look on this.
Moved options from composer command into configuration file and added documentation for requirements array.
There was a problem hiding this comment.
Looks good to me 👍
Thanks for making these changes, it's a really nice addition.
@Jibbarth Could you make a quick review of this, overall I think it's pretty clean. But as I have been more involved in this one, I think a quick look by you would be nice.
| ]; | ||
| foreach ($requirements as $requirement) { | ||
| if ($input->hasParameterOption('--'.$requirement)) { | ||
| $config['requirements'][$requirement] = $input->getOption($requirement); |
|
@Jibbarth Haha, I always forget about the docs 😅 |
|
@Jibbarth I made the last changes, so I think this should be ready now 😄 |
There was a problem hiding this comment.
@olivernybroe No doc update ? 😅
If you can add it, would be perfect 👌 Can be done later if you prefer 😉
I approve, I let you merge 👍
|
@DevYK Thanks a lot for the work on this! ❤️ |
|
@DevYK do you have a twitter so we can tag you in the release? |
|
@olivernybroe sure, @wioncy if not too late :) |
|
Tagged you in a comment and will fix it in the blog post :) |
This PR makes min-requirements configurable via configuration file