Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement #2056

Closed
wants to merge 3 commits into from
Closed

Conversation

Chahrezedsouidi
Copy link

No description provided.

@CLAassistant
Copy link

CLAassistant commented Jun 8, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

❌ 7imad
❌ SaraCherfi
You have signed the CLA already but the status is still pending? Let us recheck it.

@FelixNumworks
Copy link
Contributor

Hi ! Thanks for contributing to our project, but I'm not sure what this PR is about.

From what I understand, the first commit is a function to find theta given a point on a polar curve. It's written in python but saved in a .cpp file, and has no link with the main project at all. I don't think this should be pushed here.

The two other commits are a function that computes the angle between two vectors. Do you want to add a feature to the calculation app ? If yes, please consider opening an issue, or explain in the first post of your PR what you're aiming to do.

For now, this PR and the other one you opened look more like a personnal project than a contribution. It has no link with Epsilon at all. I'll close them both and you can reopen a clearer one if you still have a feature suggestion.

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants