Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: vanilla ae with independent channels #392

Merged
merged 17 commits into from
Jun 13, 2024
Merged

feat: vanilla ae with independent channels #392

merged 17 commits into from
Jun 13, 2024

Conversation

ab93
Copy link
Member

@ab93 ab93 commented Jun 12, 2024

Note: Will remove data

@ab93 ab93 changed the title Feat/ic vanilla feat: vanilla ae with independent channels Jun 12, 2024
Signed-off-by: Avik Basu <[email protected]>
Copy link

codecov bot commented Jun 12, 2024

Codecov Report

Attention: Patch coverage is 97.56098% with 3 lines in your changes missing coverage. Please review.

Project coverage is 92.61%. Comparing base (0e1a928) to head (80dcfb1).

Files Patch % Lines
numalogic/models/autoencoder/variants/icvanilla.py 97.10% 1 Missing and 1 partial ⚠️
numalogic/tools/layer.py 97.43% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #392      +/-   ##
==========================================
+ Coverage   92.53%   92.61%   +0.08%     
==========================================
  Files          98       99       +1     
  Lines        4664     4756      +92     
  Branches      413      419       +6     
==========================================
+ Hits         4316     4405      +89     
- Misses        254      256       +2     
- Partials       94       95       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ab93 ab93 requested a review from mboussarov June 12, 2024 00:31
Copy link
Contributor

@mboussarov mboussarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ab93 ab93 marked this pull request as ready for review June 12, 2024 23:09
@ab93 ab93 self-assigned this Jun 12, 2024
@ab93 ab93 removed the DO NOT MERGE label Jun 12, 2024
Copy link
Contributor

@s0nicboOm s0nicboOm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

knitpick otherwise lgtm

@ab93 ab93 merged commit 8f6c8ef into main Jun 13, 2024
13 checks passed
@ab93 ab93 deleted the feat/ic-vanilla branch June 13, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants