Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve metadata serialization #244

Merged
merged 2 commits into from
Aug 16, 2023
Merged

Conversation

s0nicboOm
Copy link
Contributor

@s0nicboOm s0nicboOm commented Aug 16, 2023

improve metadata serialization with orjson instead of torch serialization.

Method Time Taken (1000 calls)
torch 70ms
json 2 ms
orjson 0.3 ms
ujson. 0.8 ms

@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #244 (99c9312) into main (8482c01) will decrease coverage by 0.14%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #244      +/-   ##
==========================================
- Coverage   96.45%   96.31%   -0.14%     
==========================================
  Files          53       53              
  Lines        2226     2227       +1     
  Branches      174      174              
==========================================
- Hits         2147     2145       -2     
- Misses         56       58       +2     
- Partials       23       24       +1     
Files Changed Coverage Δ
numalogic/registry/redis_registry.py 97.69% <100.00%> (+0.01%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@vigith
Copy link
Member

vigith commented Aug 16, 2023

rust, eh 😁

Signed-off-by: kbatra <[email protected]>
@s0nicboOm s0nicboOm marked this pull request as ready for review August 16, 2023 20:02
@s0nicboOm s0nicboOm merged commit 52a65c0 into numaproj:main Aug 16, 2023
10 checks passed
@s0nicboOm s0nicboOm deleted the redis_fix branch August 16, 2023 20:43
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants