Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples: update with new numalogic and pynumaflow #202

Merged
merged 6 commits into from
Jun 2, 2023
Merged

Conversation

ab93
Copy link
Member

@ab93 ab93 commented Jun 1, 2023

  • update examples for numalogic version and pynumaflow versions
  • base numalogic udf
  • class-based udfs
  • remove protobuf 3.20 requirement

@ab93 ab93 self-assigned this Jun 1, 2023
@ab93 ab93 requested review from vigith and mboussarov June 1, 2023 18:05
@ab93 ab93 marked this pull request as ready for review June 1, 2023 18:07
@codecov
Copy link

codecov bot commented Jun 1, 2023

Codecov Report

Merging #202 (a393dcf) into main (2298be4) will decrease coverage by 0.03%.
The diff coverage is 93.33%.

❗ Current head a393dcf differs from pull request most recent head 28d1380. Consider uploading reports for the commit 28d1380 to get more accurate results

@@            Coverage Diff             @@
##             main     #202      +/-   ##
==========================================
- Coverage   96.26%   96.23%   -0.03%     
==========================================
  Files          38       40       +2     
  Lines        1578     1593      +15     
  Branches      124      125       +1     
==========================================
+ Hits         1519     1533      +14     
- Misses         43       44       +1     
  Partials       16       16              
Impacted Files Coverage Δ
numalogic/numaflow/_base.py 92.30% <92.30%> (ø)
numalogic/numaflow/__init__.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@nkoppisetty nkoppisetty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ab93 ab93 requested a review from shashank10456 June 2, 2023 18:20
@ab93 ab93 added this to the v0.4 milestone Jun 2, 2023
Signed-off-by: Avik Basu <[email protected]>
@ab93 ab93 removed the DO NOT MERGE label Jun 2, 2023
@ab93 ab93 merged commit 4411aa7 into main Jun 2, 2023
7 checks passed
@ab93 ab93 deleted the example-upgrade branch June 2, 2023 19:58
ab93 added a commit that referenced this pull request Jun 2, 2023
- update examples for numalogic version and pynumaflow versions
- base numalogic udf
- pynumaflow as an optional dependency
- class-based udfs
- remove protobuf 3.20 requirement

---------

Signed-off-by: Avik Basu <[email protected]>
ab93 added a commit that referenced this pull request Jun 2, 2023
- update examples for numalogic version and pynumaflow versions
- base numalogic udf
- pynumaflow as an optional dependency
- class-based udfs
- remove protobuf 3.20 requirement

---------

Signed-off-by: Avik Basu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants