Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark v0.4 #163

Merged
merged 9 commits into from
May 2, 2023
Merged

Benchmark v0.4 #163

merged 9 commits into from
May 2, 2023

Conversation

ab93
Copy link
Member

@ab93 ab93 commented Apr 26, 2023

Benchmarking with respect to a subset of a public dataset.

@codecov
Copy link

codecov bot commented Apr 26, 2023

Codecov Report

Merging #163 (89955e4) into main (ed40681) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #163      +/-   ##
==========================================
+ Coverage   97.29%   97.30%   +0.01%     
==========================================
  Files          33       33              
  Lines        1293     1298       +5     
  Branches       96       96              
==========================================
+ Hits         1258     1263       +5     
  Misses         26       26              
  Partials        9        9              
Impacted Files Coverage Δ
numalogic/config/_config.py 100.00% <100.00%> (ø)
numalogic/tools/data.py 96.87% <100.00%> (+0.20%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

ab93 and others added 4 commits April 26, 2023 13:33
Signed-off-by: Avik Basu <[email protected]>
Signed-off-by: Avik Basu <[email protected]>
Signed-off-by: Avik Basu <[email protected]>
Signed-off-by: Avik Basu <[email protected]>
@ab93 ab93 marked this pull request as ready for review April 28, 2023 19:05
@ab93 ab93 requested review from vigith and mboussarov April 28, 2023 19:13
Copy link

@qhuai qhuai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

initial comments

benchmarks/README.md Outdated Show resolved Hide resolved
benchmarks/kpi/datamodule.py Show resolved Hide resolved
benchmarks/kpi/datamodule.py Outdated Show resolved Hide resolved
benchmarks/README.md Show resolved Hide resolved
Avik Basu added 2 commits May 1, 2023 13:50
Signed-off-by: Avik Basu <[email protected]>
@ab93 ab93 added this to the v0.4 milestone May 1, 2023
@ab93 ab93 requested a review from qhuai May 1, 2023 18:55
@ab93 ab93 requested a review from s0nicboOm May 2, 2023 17:43
Signed-off-by: Avik Basu <[email protected]>
@ab93 ab93 merged commit 73bbad2 into numaproj:main May 2, 2023
@ab93 ab93 deleted the benchmark-v0.4 branch May 2, 2023 19:05
ab93 added a commit that referenced this pull request May 5, 2023
@ab93 ab93 mentioned this pull request May 5, 2023
ab93 added a commit that referenced this pull request May 8, 2023
* docs: updated CHANGELOG.md (#158)
* chore!: use torch and lightning 2.0 (#159)
* feat: support weight decay in optimizers (#161)
* feat: first benchmarking using KPI anomaly data (#163)
* chore!: drop support for python 3.8 (#164)
* chore: introduce ruff as a linter (#167)
* feat: local memory artifact cache (#165)
* feat: in-memory cache
* feat: redis registry (#170)
* chore: allow actions for release branches (#174)
* fix: accelerator
---------

Signed-off-by: GitHub <[email protected]>
Signed-off-by: Avik Basu <[email protected]>
Signed-off-by: s0nicboOm <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: ab93 <[email protected]>
Co-authored-by: Kushal Batra <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants