fix: adjust factor

Signed-off-by: Avik Basu <[email protected]>

numalogic/models/threshold/_median.py

@@ -22,20 +22,29 @@ class MaxPercentileThreshold(BaseThresholdModel):
  min_threshold: Value to be used if threshold is less than this
  """
 
- __slots__ = ("_max_percentile", "_min_thresh", "_thresh", "_is_fitted", "_adjust_threshold")
+ __slots__ = (
+ "_max_percentile",
+ "_min_thresh",
+ "_thresh",
+ "_is_fitted",
+ "_adjust_threshold",
+ "_adjust_factor",
+ )
 
  def __init__(
  self,
  max_inlier_percentile: float = 96.0,
  min_threshold: float = 1e-4,
  adjust_threshold: bool = False,
+ adjust_factor: float = 3.0,
  ):
  super().__init__()
  self._max_percentile = max_inlier_percentile
  self._min_thresh = min_threshold
  self._thresh = None
  self._is_fitted = False
  self._adjust_threshold = adjust_threshold
+ self._adjust_factor = adjust_factor
 
  @property
  def threshold(self):
@@ -53,13 +62,15 @@ def fit(self, x: npt.NDArray[float]) -> Self:
 
  if self._adjust_threshold:
  for idx, _ in enumerate(self._thresh):
- if self._thresh[idx] / self._min_thresh < 1e-2:
+ ratio = self._thresh[idx] / self._min_thresh
+ if ratio < 1e-2:
  LOGGER.info(
- "Min threshold is less than 1e-2 times the "
- "threshold for column %s; Using mean instead.",
+ "Min threshold ratio: %s is less than 1e-2 times the "
+ "threshold for column %s;",
+ ratio,
  idx,
  )
- self._thresh[idx] = np.mean(x[:, idx]) + (3 * np.std(x[:, idx]))
+ self._thresh[idx] = self._min_thresh * self._adjust_factor
 
  self._thresh[self._thresh < self._min_thresh] = self._min_thresh
  self._is_fitted = True