fix: comments

Signed-off-by: Avik Basu <[email protected]>
numaproj · Feb 6, 2024 · b41a7f7 · b41a7f7
1 parent 780f2e2
commit b41a7f7
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 7 deletions.
diff --git a/numalogic/tools/aggregators.py b/numalogic/tools/aggregators.py
@@ -1,4 +1,3 @@
-import os
 from collections.abc import Callable
 
 import numpy as np
@@ -7,9 +6,6 @@
 from numalogic.transforms import expmov_avg_aggregator
 
 
-EXP_MOV_AVG_BETA = float(os.getenv("EXP_MOV_AVG_BETA", "0.6"))
-
-
 def aggregate_window(
  y: npt.NDArray[float], agg_func: Callable = expmov_avg_aggregator, **agg_func_kw
 ) -> npt.NDArray[float]:

diff --git a/numalogic/udfs/postprocess.py b/numalogic/udfs/postprocess.py
@@ -30,7 +30,6 @@
 LOCAL_CACHE_TTL = int(os.getenv("LOCAL_CACHE_TTL", "3600"))
 LOCAL_CACHE_SIZE = int(os.getenv("LOCAL_CACHE_SIZE", "10000"))
 LOAD_LATEST = os.getenv("LOAD_LATEST", "false").lower() == "true"
-EXP_MOV_AVG_BETA = float(os.getenv("EXP_MOV_AVG_BETA", "0.6"))
 
 _LOGGER = logging.getLogger(__name__)
 
@@ -196,7 +195,12 @@ def exec(self, keys: list[str], datum: Datum) -> Messages:
 
  @staticmethod
  def _per_feature_score(feat_names: list[str], scores: NDArray[float]) -> dict[str, float]:
- if len(scores) != len(feat_names):
+ if (scores_len := len(scores)) != len(feat_names):
+ _LOGGER.debug(
+ "Scores length: %s does not match feat_names: %s",
+ scores_len,
+ feat_names,
+ )
  return {}
  return dict(zip(feat_names, scores))
 

diff --git a/tests/udfs/test_postprocess.py b/tests/udfs/test_postprocess.py
@@ -157,7 +157,6 @@ def test_postprocess_all_model_present_02(self):
 
  msg = udf(KEYS, Datum(keys=KEYS, value=orjson.dumps(data), **DATUM_KW))
  payload = OutputPayload(**orjson.loads(msg[0].value))
- print(payload)
  self.assertFalse(list(payload.data))
  self.assertEqual(1, len(msg))