Skip to content

Commit

Permalink
chore!: make mlflow as an optional dependency
Browse files Browse the repository at this point in the history
Signed-off-by: Avik Basu <[email protected]>
  • Loading branch information
ab93 committed Oct 17, 2022
1 parent 9cc97cb commit 8969e80
Show file tree
Hide file tree
Showing 5 changed files with 1,220 additions and 339 deletions.
9 changes: 6 additions & 3 deletions numalogic/registry/__init__.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
from numalogic.registry.artifact import ArtifactManager
from numalogic.registry.mlflow_registry import MLflowRegistrar


__all__ = ["ArtifactManager", "MLflowRegistrar"]
try:
from numalogic.registry.mlflow_registry import MLflowRegistrar
except ImportError:
__all__ = ["ArtifactManager"]
else:
__all__ = ["ArtifactManager", "MLflowRegistrar"]
2 changes: 2 additions & 0 deletions numalogic/tests/registry/_mlflow_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,7 @@ def mock_log_model_pytorch(*_, **__):
signature_dict=None,
utc_time_created="2022-05-23 22:35:59.557372",
mlflow_version="1.26.0",
signature=None
)


Expand All @@ -133,6 +134,7 @@ def mock_log_model_sklearn(*_, **__):
signature_dict=None,
utc_time_created="2022-05-23 22:35:59.557372",
mlflow_version="1.26.0",
signature=None
)


Expand Down
5 changes: 1 addition & 4 deletions numalogic/tools/types.py
Original file line number Diff line number Diff line change
@@ -1,15 +1,12 @@
from typing import Union, Dict, NewType, TypeVar, Sequence, Optional

from mlflow.entities.model_registry import ModelVersion
from sklearn.base import BaseEstimator, TransformerMixin
from sklearn.pipeline import Pipeline
from torch import nn

Artifact = NewType("Artifact", Union[nn.Module, BaseEstimator, TransformerMixin, Pipeline])
ArtifactDict = NewType(
"ArtifactDict",
Optional[
Dict[str, Union[Sequence[Artifact], Dict[str, Artifact], Artifact, None, ModelVersion]]
],
Optional[Dict[str, Union[Sequence[Artifact], Dict[str, Artifact], Artifact, None]]],
)
AutoencoderModel = TypeVar("AutoencoderModel", bound="TorchAE")
Loading

0 comments on commit 8969e80

Please sign in to comment.