chore: Configure TTL for Serving Source Store #1845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yashash H L <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1845 +/- ##
==========================================
+ Coverage 54.27% 54.36% +0.08%
==========================================
Files 283 284 +1
Lines 27975 28020 +45
==========================================
+ Hits 15184 15232 +48
+ Misses 11886 11875 -11
- Partials 905 913 +8 ☔ View full report in Codecov by Sentry. |
vigith
reviewed
Jul 17, 2024
Comment on lines
72
to
81
| conn_manager | ||
| .send_packed_command(redis::cmd(LPUSH).arg(key).arg(val)) | ||
| .await | ||
| .map(|_| ()) | ||
| .await?; | ||
|
|
||
| // if the ttl is configured, set the key to expire after the specified time | ||
| if let Some(ttl) = config().redis.ttl_secs { | ||
| conn_manager | ||
| .send_packed_command(redis::cmd(EXPIRE).arg(key).arg(ttl)) | ||
| .await?; | ||
| } |
There was a problem hiding this comment.
use pipelining? meaning, send both the commands together
Signed-off-by: Yashash H L <[email protected]>
Signed-off-by: Vigith Maurice <[email protected]>
vigith
reviewed
Jul 17, 2024
Comment on lines
300
to
305
| // Immediately check existence | ||
| let exists: bool = conn_manager | ||
| .exists(&key) | ||
| .await | ||
| .expect("Failed to check existence immediately"); | ||
| assert!(exists, "Key should exist immediately after saving"); |
There was a problem hiding this comment.
use TTL command to see whether the value has been set. do not sleep. check for existence or TTL being set.
Signed-off-by: Yashash H L <[email protected]>
vigith
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: