Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render components inside of buttons #280

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Korab-Doroci
Copy link

@Korab-Doroci Korab-Doroci commented Jun 11, 2024

As the title says this simple change will allow you to put components from layout.html or another .nue file inside of buttons inside of your markdown. Fixes #277

@nobkd nobkd requested a review from tipiirai June 11, 2024 22:14
@nobkd
Copy link
Collaborator

nobkd commented Jun 12, 2024

@Korab-Doroci
Can you create a test, that checks, whether this creates the expected results, please? Thanks.

@Korab-Doroci
Copy link
Author

As mentioned before, it will only work if the svg or other component is inside a .nue file. With this change it will not work if the component is inside the layout.html.

@tipiirai
Copy link
Contributor

I'm thinking of a [link] tag (or similar) for this use case. I think button should not allow any markup inside since the HTML spec only allows phrasing content

@nobkd nobkd added the nuemark Related to nuemark package label Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
nuemark Related to nuemark package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nuemark: How to add svg inside a button
3 participants