fix: accessing child's update function #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tipiirai, can you help me add a test for this case? |
|
Looks solid. If anything, I'd like to have a solid server-side test runner for the client-side Nue JS library. Currently the test suite is client-side only and thus not ideal. Cannot be run with GitHub actions etc. I know, It's quite a big task to implement — but it's something that has to be done at some point when the single-page application pieces start to become relevant. Ideally the suite should be super lightweight based on a tiny JavaScript test library and not those monster Chromleess browser/server/cloud services. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
updatefunction toimplproperty even if the script tag is empty.Fixes #103