Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a validator ordering issue with PVSS & DKG instances #95

Merged
merged 9 commits into from
Apr 24, 2023

Conversation

piotr-roslaniec
Copy link

@piotr-roslaniec piotr-roslaniec commented Apr 20, 2023

  • Browse the commits one by one to follow the developments of this story
  • Replaces implicit ordering with explicit ordering and validity checks
  • Changes how the ordering of shares and validators is tracked within DKG

@codecov-commenter
Copy link

codecov-commenter commented Apr 20, 2023

Codecov Report

Merging #95 (f6cf412) into main (da5e55e) will decrease coverage by 1.13%.
The diff coverage is 84.75%.

@@            Coverage Diff             @@
##             main      #95      +/-   ##
==========================================
- Coverage   81.78%   80.65%   -1.13%     
==========================================
  Files          25       23       -2     
  Lines        3975     4157     +182     
==========================================
+ Hits         3251     3353     +102     
- Misses        724      804      +80     
Impacted Files Coverage Δ
ferveo-python/src/lib.rs 0.29% <0.00%> (-0.03%) ⬇️
tpke-wasm/src/lib.rs 72.81% <0.00%> (ø)
tpke/src/api.rs 0.00% <0.00%> (ø)
ferveo-common/src/lib.rs 44.82% <42.85%> (+22.60%) ⬆️
ferveo-common/src/keypair.rs 71.05% <65.74%> (-13.40%) ⬇️
ferveo/src/api.rs 84.77% <69.56%> (+1.93%) ⬆️
ferveo-common/src/utils.rs 94.73% <93.75%> (-5.27%) ⬇️
ferveo/src/pvss.rs 90.13% <95.71%> (ø)
ferveo/src/dkg.rs 95.68% <96.11%> (+95.68%) ⬆️
ferveo/src/lib.rs 100.00% <100.00%> (ø)
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@piotr-roslaniec piotr-roslaniec changed the title Document an ordering issue with PVSS & DKG instances Fix a validator ordering issue with PVSS & DKG instances Apr 20, 2023
@piotr-roslaniec piotr-roslaniec marked this pull request as ready for review April 20, 2023 09:38
@piotr-roslaniec piotr-roslaniec merged commit 9fded5b into nucypher:main Apr 24, 2023
@piotr-roslaniec piotr-roslaniec deleted the implicit-ordering branch April 24, 2023 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

2 participants