Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Protobuf: fix false positives #2428

Merged
merged 1 commit into from
May 9, 2024
Merged

Protobuf: fix false positives #2428

merged 1 commit into from
May 9, 2024

Conversation

IvanNardi
Copy link
Collaborator

No description provided.

@IvanNardi IvanNardi requested a review from utoni May 8, 2024 19:31
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

utoni
utoni approved these changes May 9, 2024
View reviewed changes
Copy link
Collaborator

@utoni utoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we're loosing one protobuf flow, but it's just a one packet flow, so I guess it's alright

@IvanNardi
Copy link
Collaborator Author

we're loosing one protobuf flow, but it's just a one packet flow, so I guess it's alright

If you open that trace, that Protobuf classification seems wrong anyway....

@IvanNardi IvanNardi merged commit 2e7fc82 into ntop:dev May 9, 2024
32 of 33 checks passed
@IvanNardi IvanNardi deleted the protobuf-false-positives branch May 9, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@utoni utoni utoni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@IvanNardi @utoni