feat(devkit): bump compatibility to Nx 19 - 21.x #28243
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit d171474. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targets
Sent with 💌 from NxCloud. |
ba3e29f
to
398bcf0
Compare
398bcf0
to
c88b5fc
Compare
c88b5fc
to
41878da
Compare
03fe7fb
to
5cce313
Compare
250b702
to
e8855e8
Compare
e8855e8
to
b2f7ab6
Compare
b2f7ab6
to
93cad78
Compare
93cad78
to
abd4a3a
Compare
abd4a3a
to
17b621c
Compare
17b621c
to
398663c
Compare
| 'node:sea', | ||
| 'node:sqlite', | ||
| ]); | ||
| const experimentalNodeModules = new Set(['node:sqlite']); |
There was a problem hiding this comment.
Is this necessary? If you run with node --experimental-sqlite then isBuiltin from node:module already includes node:sqlite.
There was a problem hiding this comment.
Sometimes Nx Console starts the daemon and probably won't run with --experimental-sqlite so this ensure that it's handled regardless of it's passed or not.
| import { combineGlobPatterns } from '../../utils/globs'; | ||
|
|
||
| import type { NxPluginV1 } from '../../utils/nx-plugin.deprecated'; | ||
| import type { LoadedNxPlugin, NormalizedPlugin } from './internal-api'; | ||
| import { |
There was a problem hiding this comment.
Are there changes to the V2 public APIs? I see that CreateNodesV2 is slated for removal in v21, and users should be using CreateNodes instead. Is that part of v20 changes?
There was a problem hiding this comment.
We'll do this in Nx 21.. because there's not enough time at the moment.
f480850
to
8101b56
Compare
8101b56
to
05c0531
Compare
05c0531
to
d171474
Compare
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
BREAKING CHANGE
Current Behavior
@nx/devkitsupports Nx 17 - 20.ExecutorContext.projectGraph,ExecutorContext.nxJsonConfiguration, andExecutorContext.projectsConfigurationsis marked as optional becauseExecutorContextin some versions of Nx did not have them.ExecutorContext.workspaceis marked as optional becauseExecutorContextin some versions of Nx did not have the above properties which contain the same information.ProjectGraphNodeis deprecated.NxPluginV1.processProjectGraphwas deprecated long ago and there has been a warning since.appRootPathhas been deprecated for a long time.parseTargetStringhad a variant that did not take either the project graph or the executor context.readNxJsonhas a variant which does not take a tree. This was not clearly deprecated.@nx/instead of@nrwl@nrwl/cliExpected Behavior
@nx/devkitsupports Nx 19 - 21.ExecutorContext.projectGraph,ExecutorContext.nxJsonConfiguration, andExecutorContext.projectsConfigurationsis marked as required becauseExecutorContextin Nx 19+ is guaranteed to have them.ExecutorContext.workspaceis removed because the same information is available in the above propertiesProjectGraphNodeis removed.NxPluginV1is no more. All plugins should beNxPluginV2.workspaceRootis the replacement forappRootPath.appRootPathis removed.parseTargetStringno longer has a variant that did not take either the project graph or the executor context.readNxJsonstill has a variant which does not take a tree but it's clearly deprecated to be removed in Nx 21.@nrwlpackages are no more so we don't have to redirect requires anymore.@nrwl/cliis no more so Nx shouldn't try to get a root install thereRelated Issue(s)
Fixes #