Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up addons #7

Merged
merged 1 commit into from
Jul 3, 2018
Merged

clean up addons #7

merged 1 commit into from
Jul 3, 2018

Conversation

vsavkin
Copy link
Member

@vsavkin vsavkin commented Jun 29, 2018

  • Updates the addons page to be more similar to schematics and tasks
  • Clean ups the server

@mrmeku i added the "busy" observable to the CommandRunner. If you open workspace.component.html, you will see:

      <span *ngIf="commandRunner.busy|async"> &nbsp;  ...Spinner Added Here...</span>

You probably want to remove this and use the "busy" observable in a more intelligent way.

@vsavkin vsavkin merged commit f1f44e7 into master Jul 3, 2018
@vsavkin vsavkin deleted the cleanup-addons branch July 12, 2018 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant