Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(repo): enable plugin isolation and bump nx #2194

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .env
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
NX_ISOLATE_PLUGINS=true
9 changes: 7 additions & 2 deletions .eslintrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -52,13 +52,18 @@
"argsIgnorePattern": "^_$"
}
],
"@typescript-eslint/no-explicit-any": "off"
"@typescript-eslint/no-explicit-any": "off",
"@typescript-eslint/no-extra-semi": "error",
"no-extra-semi": "off"
}
},
{
"files": ["*.js", "*.jsx"],
"extends": ["plugin:@nx/javascript"],
"rules": {}
"rules": {
"@typescript-eslint/no-extra-semi": "error",
"no-extra-semi": "off"
}
},
{
"files": ["*.html"],
Expand Down
4 changes: 1 addition & 3 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,6 @@ testem.log
.DS_Store
Thumbs.db

#Environment
.env

# Intellij
.gradle
.qodana
Expand All @@ -68,4 +65,5 @@ apps/vscode-e2e/.screenshots
.angular

.nx/cache
.nx/workspace-data
**/cypress/downloads
3 changes: 2 additions & 1 deletion .prettierignore
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,5 @@ CHANGELOG.md
apps/intellij/*
!apps/intellij/project.json

/.nx/cache
/.nx/cache
/.nx/workspace-data
17 changes: 17 additions & 0 deletions build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,20 @@ tasks {
gradleVersion = project.findProperty("gradleVersion").toString()
}
}

allprojects {
apply {
plugin("project-report")
}
}
tasks.register("projectReportAll") {
// All project reports of subprojects
allprojects.forEach {
dependsOn(it.tasks.get("projectReport"))
}

// All projectReportAll of included builds
gradle.includedBuilds.forEach {
dependsOn(it.task(":projectReportAll"))
}
}
Expand Down
77 changes: 50 additions & 27 deletions migrations.json
Original file line number Diff line number Diff line change
@@ -1,56 +1,79 @@
{
"migrations": [
{
"version": "18.1.0-beta.3",
"description": "Moves affected.defaultBase to defaultBase in `nx.json`",
"implementation": "./src/migrations/update-17-2-0/move-default-base",
"cli": "nx",
"version": "19.2.0-beta.2",
"description": "Updates the default workspace data directory to .nx/workspace-data",
"implementation": "./src/migrations/update-19-2-0/move-workspace-data-directory",
"package": "nx",
"name": "move-default-base-to-nx-json-root"
"name": "19-2-0-move-graph-cache-directory"
},
{
"cli": "nx",
"version": "18.1.0-beta.3",
"description": "Update to Cypress ^13.6.6 if the workspace is using Cypress v13 to ensure workspaces don't use v13.6.5 which has an issue when verifying Cypress.",
"implementation": "./src/migrations/update-18-1-0/update-cypress-version-13-6-6",
"package": "@nx/cypress",
"name": "update-cypress-version-13-6-6"
"version": "19.2.2-beta.0",
"description": "Updates the nx wrapper.",
"implementation": "./src/migrations/update-17-3-0/update-nxw",
"package": "nx",
"name": "19-2-2-update-nx-wrapper"
},
{
"version": "19.2.4-beta.0",
"description": "Set project name in nx.json explicitly",
"implementation": "./src/migrations/update-19-2-4/set-project-name",
"x-repair-skip": true,
"package": "nx",
"name": "19-2-4-set-project-name"
},
{
"cli": "nx",
"version": "18.1.0-beta.1",
"requires": {
"@angular/core": ">=17.2.0"
},
"description": "Update the @angular/cli package version to ~17.2.0.",
"factory": "./src/migrations/update-18-1-0/update-angular-cli",
"package": "@nx/angular",
"name": "update-angular-cli-version-17-2-0"
"version": "19.1.0-beta.6",
"description": "Migrate no-extra-semi rules into user config, out of nx extendable configs",
"implementation": "./src/migrations/update-19-1-0-migrate-no-extra-semi/migrate-no-extra-semi",
"package": "@nx/eslint-plugin",
"name": "update-19-1-0-rename-no-extra-semi"
},
{
"cli": "nx",
"version": "18.1.1-beta.0",
"description": "Ensure targetDefaults inputs for task hashing when '@nx/angular:webpack-browser' is used are correct for Module Federation.",
"factory": "./src/migrations/update-18-1-1/fix-target-defaults-inputs",
"version": "19.1.0-beta.2",
"requires": {
"@angular/core": ">=18.0.0"
},
"description": "Update the @angular/cli package version to ~18.0.0.",
"factory": "./src/migrations/update-19-1-0/update-angular-cli",
"package": "@nx/angular",
"name": "fix-target-defaults-for-webpack-browser"
"name": "update-angular-cli-version-18-0-0"
},
{
"cli": "nx",
"version": "18.2.0-beta.0",
"version": "19.2.1-beta.0",
"requires": {
"@angular/core": ">=17.3.0"
"@angular-eslint/eslint-plugin": ">=18.0.0"
},
"description": "Update the @angular/cli package version to ~17.3.0.",
"factory": "./src/migrations/update-18-2-0/update-angular-cli",
"description": "Installs the '@typescript-eslint/utils' package when having installed '@angular-eslint/eslint-plugin' or '@angular-eslint/eslint-plugin-template' with version >=18.0.0.",
"factory": "./src/migrations/update-19-2-1/add-typescript-eslint-utils",
"package": "@nx/angular",
"name": "update-angular-cli-version-17-3-0"
"name": "add-typescript-eslint-utils"
},
{
"version": "17.3.0",
"version": "18.0.0",
"description": "Updates two-way bindings that have an invalid expression to use the longform expression instead.",
"factory": "./migrations/invalid-two-way-bindings/bundle",
"package": "@angular/core",
"name": "invalid-two-way-bindings"
},
{
"version": "18.0.0",
"description": "Replace deprecated HTTP related modules with provider functions",
"factory": "./migrations/http-providers/bundle",
"package": "@angular/core",
"name": "migration-http-providers"
},
{
"version": "18.0.0-0",
"description": "Updates the Angular CDK to v18",
"factory": "./ng-update/index#updateToV18",
"package": "@angular/cdk",
"name": "migration-v18"
}
]
}
75 changes: 38 additions & 37 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -48,46 +48,46 @@
},
"devDependencies": {
"@angular-builders/custom-webpack": "^16.0.0",
"@angular-devkit/build-angular": "17.3.1",
"@angular-devkit/core": "17.3.1",
"@angular-devkit/schematics": "17.3.1",
"@angular-eslint/eslint-plugin": "17.3.0",
"@angular-eslint/eslint-plugin-template": "17.3.0",
"@angular-eslint/template-parser": "17.3.0",
"@angular/animations": "17.3.1",
"@angular/cdk": "17.3.1",
"@angular/cli": "~17.3.0",
"@angular/common": "17.3.1",
"@angular/compiler": "17.3.1",
"@angular/compiler-cli": "17.3.1",
"@angular/core": "17.3.1",
"@angular/forms": "17.3.1",
"@angular/platform-browser": "17.3.1",
"@angular/platform-browser-dynamic": "17.3.1",
"@angular-devkit/build-angular": "18.0.6",
"@angular-devkit/core": "18.0.6",
"@angular-devkit/schematics": "18.0.6",
"@angular-eslint/eslint-plugin": "18.0.1",
"@angular-eslint/eslint-plugin-template": "18.0.1",
"@angular-eslint/template-parser": "18.0.1",
"@angular/animations": "18.0.5",
"@angular/cdk": "18.0.5",
"@angular/cli": "~18.0.0",
"@angular/common": "18.0.5",
"@angular/compiler": "18.0.5",
"@angular/compiler-cli": "18.0.5",
"@angular/core": "18.0.5",
"@angular/forms": "18.0.5",
"@angular/platform-browser": "18.0.5",
"@angular/platform-browser-dynamic": "18.0.5",
"@babel/core": "7.21.0",
"@nx/angular": "19.0.4",
"@nx/cypress": "19.0.4",
"@nx/devkit": "19.0.4",
"@nx/esbuild": "19.0.4",
"@nx/eslint": "19.0.4",
"@nx/eslint-plugin": "19.0.4",
"@nx/gradle": "19.0.4",
"@nx/jest": "19.0.4",
"@nx/js": "19.0.4",
"@nx/node": "19.0.4",
"@nx/storybook": "19.0.4",
"@nx/web": "19.0.4",
"@nx/webpack": "19.0.4",
"@nx/workspace": "19.0.4",
"@schematics/angular": "17.3.1",
"@nx/angular": "19.4.0-rc.0",
"@nx/cypress": "19.4.0-rc.0",
"@nx/devkit": "19.4.0-rc.0",
"@nx/esbuild": "19.4.0-rc.0",
"@nx/eslint": "19.4.0-rc.0",
"@nx/eslint-plugin": "19.4.0-rc.0",
"@nx/gradle": "19.4.0-rc.0",
"@nx/jest": "19.4.0-rc.0",
"@nx/js": "19.4.0-rc.0",
"@nx/node": "19.4.0-rc.0",
"@nx/storybook": "19.4.0-rc.0",
"@nx/web": "19.4.0-rc.0",
"@nx/webpack": "19.4.0-rc.0",
"@nx/workspace": "19.4.0-rc.0",
"@schematics/angular": "18.0.6",
"@storybook/addon-essentials": "7.5.3",
"@storybook/addon-knobs": "~7.0.2",
"@storybook/addon-mdx-gfm": "7.5.3",
"@storybook/angular": "7.5.3",
"@storybook/core-server": "7.5.3",
"@swc-node/register": "1.8.0",
"@swc/core": "~1.3.85",
"@swc/helpers": "~0.5.2",
"@swc-node/register": "1.9.2",
"@swc/core": "1.5.7",
"@swc/helpers": "0.5.11",
"@tailwindcss/forms": "0.5.3",
"@theunderscorer/nx-semantic-release": "2.4.0",
"@types/find-cache-dir": "^3.2.1",
Expand All @@ -101,6 +101,7 @@
"@types/vscode-webview": "^1.57.0",
"@typescript-eslint/eslint-plugin": "7.4.0",
"@typescript-eslint/parser": "7.4.0",
"@typescript-eslint/utils": "^8.0.0-alpha.28",
"@vscode/test-electron": "^2.1.5",
"@vscode/vsce": "^2.15.0",
"@wdio/cli": "^7.27.0",
Expand All @@ -109,7 +110,7 @@
"@wdio/mocha-framework": "^7.26.0",
"@wdio/spec-reporter": "^7.26.0",
"@yarnpkg/pnp": "^3.1.1-rc.12",
"cypress": "^13.6.6",
"cypress": "13.9.0",
"cypress-real-events": "^1.11.0",
"esbuild": "0.19.5",
"esbuild-copy-files-plugin": "^1.1.0",
Expand All @@ -123,10 +124,10 @@
"jest": "29.4.3",
"jest-environment-jsdom": "29.4.3",
"jest-environment-node": "^29.4.1",
"jest-preset-angular": "14.0.3",
"jest-preset-angular": "14.1.1",
"memfs": "^3.4.7",
"mocha": "^10.0.0",
"nx": "19.0.4",
"nx": "19.4.0-rc.0",
"ovsx": "^0.7.1",
"prettier": "2.7.1",
"prettier-plugin-tailwindcss": "^0.3.0",
Expand Down
Loading
Loading