Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(misc): add support for run-help event #2183

Merged
merged 3 commits into from
Jun 25, 2024
Merged

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Jun 21, 2024

We are showing --help content from PDV, which requires that this enhancement lands in Console first, or else run-help will do nothing.

See this for more explanation: https://www.loom.com/share/12a5e50762424ad9bb86dbf002e1116a

Copy link

nx-cloud bot commented Jun 21, 2024

Copy link
Collaborator

@MaxKless MaxKless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good already, just a few tweaks

@jaysoo jaysoo requested a review from MaxKless June 25, 2024 01:24
@jaysoo jaysoo marked this pull request as ready for review June 25, 2024 01:25
@MaxKless MaxKless merged commit 7beb868 into master Jun 25, 2024
4 checks passed
@MaxKless MaxKless deleted the feat/pdv-show-help branch June 25, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants