fix(vscode): register workspace change listener in all cases #2162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 1901171. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
MaxKless
force-pushed
the
root-watcher-nxinit
branch
from
c01398b
to
a4d324b
Compare
jaysoo
reviewed
Jun 13, 2024
| getOutputChannel().appendLine( | ||
| 'Detected Nx workspace. Refreshing workspace.' | ||
| ); | ||
| refreshWorkspaceWithBackoff(); |
There was a problem hiding this comment.
We're not awaiting here, does it matter?
There was a problem hiding this comment.
no, I don't think so. We're simply making sure the nxls is refreshed when we detect a change, there's nothing waiting for the result of this.
MaxKless
force-pushed
the
root-watcher-nxinit
branch
from
a4d324b
to
587c478
Compare
jaysoo
approved these changes
Jun 14, 2024
MaxKless
force-pushed
the
root-watcher-nxinit
branch
from
587c478
to
1901171
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.