Implement embedded-hal 1.0 I2c trait for Twi and Twim #440
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Twi
implementation is untested as I don't have any nrf51 devices.Unfortunately the
Twim
implementation isn't working correctly. Adjacent operations of the same type are specified to be carried out without an SR and SAD+R/W, which is why I avoid setting thelastrx_stop
orlasttx_stop
shortcut in that case, but when testing this I've found that trying to have two read operations in a row results in an overrun error for some reason.