Implement pulldown and pullup on input #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @simonsso, thanks for the contribution! We are about to wrap up the |
|
Thanks, Is there a better base line I could base this and further patches on to minimize extra merge conflicts on? |
|
Rebased |
jamesmunns
reviewed
Dec 28, 2018
nrf52-hal-common/src/gpio.rs
Outdated
| @@ -12,9 +12,9 @@ pub struct Input<MODE> { | |||
| /// Floating input (type state) | |||
| pub struct Floating; | |||
| // /// Pulled down input (type state) | |||
| // pub struct PullDown; | |||
| pub struct PullDown; | |||
| // /// Pulled up input (type state) | |||
There was a problem hiding this comment.
Would you mind removing these double comments? (Lines 14 and 16)
There was a problem hiding this comment.
By remove I mean // /// ... => /// ...
|
Overall looks good, thank you! If you could remove the comments, and CI passes, I'll merge this shortly! |
Removed uncommended comment
jamesmunns
approved these changes
Dec 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looked like this was prepared already, I needed to enable a pull up on my gpio so I implemented it.
Pull up is verified on nrf52dk button1 - 4
The pull-down is still untested it is however symmetrical.
Should the function names be different?
Please enjoy.