Add "Help" dialog which shows available keyboard shortcuts #735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dialog can be toggled via button in "About" or via keyboard shortcut "?"
nrenner
reviewed
Jun 16, 2023
There was a problem hiding this comment.
The dialog looks nice!
I wondered if we should reuse the tooltip texts as descriptions in order to avoid duplicate translations of similar texts, but it would probably be a lot of work gathering those and making them usable for both, and there still might be reasons to differ.
It's a bit inconsistent that we're using uppercase letters in the tooltips and lowercase in the help dialog, but I don't really mind.
nrenner
added a commit
that referenced
this pull request
Jun 16, 2023
stefankeidel
added a commit
to cxberlin/brouter-web
that referenced
this pull request
Aug 19, 2023
* upstream/master: (29 commits) Remove tile.openstreetmap.de subdomains Prevent Gpsies-style export from throwing for undefined symbols Document new export formats added in BRouter 1.7.0 and fix export error Emit console warning when using an unsupported BRouter version Add BL and TLU to VoiceHints as contained in BRouter 1.7.2 Recreate yarn.log after error Update dependency @fortawesome/fontawesome-free to v6.4.0 (nrenner#741) Update dependency leaflet-geometryutil to v0.10.2 (nrenner#740) Update dependency i18next-browser-languagedetector to v7.0.2 (nrenner#739) Update dependency codemirror to v5.65.13 (nrenner#737) Update dependency eslint to v8.43.0 (nrenner#721) Update dependency browser-sync to v2.29.3 (nrenner#720) Update babel monorepo to v7.22.5 (nrenner#719) Update dependency postcss to v8.4.24 (nrenner#718) remove 'msjsdiag.debugger-for-chrome' Fix duplicate i18n keys and update locale (nrenner#735) add overpass layer for bicycle charging (fixes nrenner#690) Add "Help" dialog which shows available keyboard shortcuts Wrap long URLs in custom layers overlay Fix Mapillary attribution ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dialog can be toggled via button in "About" or via keyboard shortcut "?"