Fix egs++ iaea phsp scoring electron energy #1077
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a bug in egs_phsp_scoring where the electron energy for IAEA phase-spaces was written as the total energy instead of the kinetic energy.
rtownson
force-pushed
the
fix-iaea-phsp-scoring
branch
from
8aabcce
to
47c8560
Compare
blakewalters
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bug in egs_phsp_scoring where the electron (and positron) energy for IAEA phase-spaces was written as the total energy instead of the kinetic energy. This is a critical bug and impacted all IAEA format phase-spaces generated from egs++ that contained charged particles.
Thanks to Erik Nilsson for reporting this issue!