Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix egs_circle_perpendicular critical bug #1072

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

rtownson
Copy link
Collaborator

Fix a bug in egs_circle_perpendicular that made the geometry invalid for any cases where the circle was expected to face away from the z-axis. Anyone who used this geometry should check their results.

This bug persisted because testing was done on a version where a similar fix had been done, but never included in the distribution.

Example that incorrectly produced a line target instead of a circle:

   :start source:
     library = egs_collimated_source
     name = isotropic_collimated_source
     :start source shape:
       type = point
       position =  900 0.000000 0.000000
     :stop source shape:
     :start target shape:
       library = egs_circle_perpendicular
       midpoint = 0 0
       radius = 25
     :stop target shape:
     charge = 0
     :start spectrum:
      type = monoenergetic
      energy = 2
     :stop spectrum:
   :stop source:

Fix a bug in egs_circle_perpendicular that made the geometry invalid for
any cases where the circle was expected to face away from the z-axis.
@rtownson rtownson added this to the Release 2024 milestone Jan 24, 2024
@ftessier ftessier assigned ftessier and rtownson and unassigned rtownson and ftessier Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants