Make function parameters in iface_mapper const when possible
#545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make all function parameters in `iface_mapper.c` `const` when possible.
Remove the unnecessary memcpy() calls in `iface_mapper.c`. `memcpy()` is worse than using struct assignment, since: 1. It also copies padding bytes, which do not need to be copied. 2. On CHERI, `memcpy()` needs to copy the capability tags of any pointer type, which makes `memcpy()` far more complicated. 3. Using `memcpy()` increases the risk of memory bugs, since we need to manually specify types and the number of bytes to copy.
Codecov Report
@@ Coverage Diff @@
## main #545 +/- ##
=======================================
Coverage 54.14% 54.14%
=======================================
Files 144 144
Lines 21036 21039 +3
=======================================
+ Hits 11389 11392 +3
Misses 9647 9647
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
mereacre
approved these changes
Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make all the function parameters in
src/utils/iface_mapper.cconstwhen possible.This PR also removes the unnecessary
memcpy()calls iniface_mapper.c.memcpy()is worse than using struct assignment, since:memcpy()needs to copy the capability tags of any pointer type, which makesmemcpy()far more complicated.memcpy()increases the risk of memory bugs, since we need to manually specify types and the number of bytes to copy.