refactor(command_mapper): make functions const
#542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the `put_command_mapper()` and `check_command_mapper()` use a `const` string as an input parameter. I've also made the `hmap` param to `check_command_mapper()` partially `const`, since we never modify it.
Codecov Report
@@ Coverage Diff @@
## main #542 +/- ##
==========================================
- Coverage 54.17% 54.16% -0.01%
==========================================
Files 144 144
Lines 21034 21036 +2
==========================================
- Hits 11395 11394 -1
- Misses 9639 9642 +3
... and 3 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
mereacre
approved these changes
Mar 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the
put_command_mapper()andcheck_command_mapper()use aconststring as an input parameter.I've also made the
hmapparam tocheck_command_mapper()partiallyconst, since we never modify it.